Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

validate_args_spec, use combine vars and in precedence #75471

Merged
merged 8 commits into from Aug 30, 2021
Merged

validate_args_spec, use combine vars and in precedence #75471

merged 8 commits into from Aug 30, 2021

Conversation

bcoca
Copy link
Member

@bcoca bcoca commented Aug 11, 2021

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

validate_argument_spec

@ansibot ansibot added affects_2.12 bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. needs_triage Needs a first human triage before being processed. small_patch support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Aug 11, 2021
@ansibot

This comment has been minimized.

Sign in to view
@ansibot ansibot added ci_verified Changes made in this PR are causing tests to fail. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed core_review In order to be merged, this PR must follow the core review workflow. labels Aug 11, 2021
@bcoca bcoca mentioned this pull request Aug 11, 2021
Open
1 task
@ansibot ansibot added has_issue module This issue/PR relates to a module. needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI. and removed ci_verified Changes made in this PR are causing tests to fail. small_patch labels Aug 12, 2021
@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. and removed needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Aug 12, 2021
@ansibot

This comment has been minimized.

Sign in to view
@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed core_review In order to be merged, this PR must follow the core review workflow. labels Aug 12, 2021
@nitzmahone nitzmahone removed the needs_triage Needs a first human triage before being processed. label Aug 12, 2021
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Aug 20, 2021
@ansibot ansibot added needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI. and removed stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. labels Aug 23, 2021
@bcoca
Copy link
Member Author

bcoca commented Aug 25, 2021

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. ci_verified Changes made in this PR are causing tests to fail. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. core_review In order to be merged, this PR must follow the core review workflow. labels Aug 25, 2021
@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. and removed ci_verified Changes made in this PR are causing tests to fail. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Aug 30, 2021
@bcoca bcoca merged commit 2462ec7 into ansible:devel Aug 30, 2021
@bcoca bcoca deleted the fix_arg_spec_validation branch August 30, 2021 17:56
bcoca added a commit to bcoca/ansible that referenced this pull request Aug 30, 2021
@bcoca
validate_args_spec, use combine vars and in precedence (ansible#75471)
69c29c6 
* combine vars and in correct precedence
* add examples

(cherry picked from commit 2462ec7)
sivel pushed a commit that referenced this pull request Sep 1, 2021
@bcoca
validate_args_spec, use combine vars and in precedence (#75471) (#75602)
8c105c0 
* combine vars and in correct precedence
* add examples

(cherry picked from commit 2462ec7)
@ansible ansible locked and limited conversation to collaborators Sep 27, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Shrews Shrews Shrews approved these changes

@samdoran samdoran samdoran approved these changes

@s-hertel s-hertel s-hertel approved these changes

Assignees
No one assigned
Labels
affects_2.12 bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. has_issue module This issue/PR relates to a module. support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@bcoca @ansibot @Shrews @samdoran @s-hertel @nitzmahone